ship: v0.2 P1 methodology framework + adapter layer #10
Reference in New Issue
Block a user
Delete Branch "phase/01-methodology-adapters"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
REQ-01..06, 08..11, 31: dial schema, methodology registry (rapid-answer, deep-report), run-config snapshots, five adapter contracts + fakes, Ollama cloud/local fallback, Tavily/DDG search, capability probe contracts, storage/secrets adapters. Verify: PASS — 0 P0, 2 P1 fixed in-phase (path traversal, probe tests), 9 P2 flagged. Gates: backend 71 tests + mypy strict + ruff; frontend 90 tests + build. Tag target v0.2.1.
---ci--- phase: 1 milestone: v0.2 status: verify persona: backend-engineer task: T-1.5 requirements: covered: [REQ-07, REQ-10] ---/ci--- Security verify (layer 3) found P1: LocalStorageAdapter accepted absolute paths and traversal names (Path('runs/x') / '/etc/passwd' escape verified). Fixed: run_id pattern ^[a-z0-9]{8}$ + artifact-name allowlist enforced at the adapter boundary, unique tmp names + fsync + asyncio.to_thread (no blocking open in async, no tmp race). Quality verify (layer 4) found P1: capability probe had zero test coverage. Fixed: probe green-path, weak-structured-output warning, endpoint-down, and list_models cloud->local fallback tests. Also wrapped raw httpx exceptions into AdapterError (exception taxonomy). 71 backend tests green.