coreci/nextcraft
7
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 77 Wiki Activity

fix(test): type the EngineError predicates in the learner-status web tests (CI #166 node-lane red triage — the QS dynamic import is untyped, so instanceof alone narrows nothing; the engine-client-identity assert.ok + InstanceType cast pattern)
CI / node (push) Failing after 32s
Details
CI / python (push) Failing after 47s
Details

Browse Source
This commit is contained in:
Amara Diallo — PO nextcraft
2026-10-21 04:43:52 +00:00
parent b489c59980
commit 38b3e07cfe
1 changed files with 15 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/web/tests/learner-placement-status.test.ts
+15 -10
View File
@@ -98,9 +98,11 @@ test("getMyApplication: no application → EngineError 404 (the apply-CTA arm)",
);
try {
const { getMyApplication, EngineError } = await import(`../lib/engine-client.ts${QS}`);
await assert.rejects(getMyApplication("post-1", "pilot-learner"), (err: unknown) =>
err instanceof EngineError && err.status === 404,
);
await assert.rejects(getMyApplication("post-1", "pilot-learner"), (err: unknown) => {
assert.ok(err instanceof EngineError, "must be EngineError");
const e = err as InstanceType<typeof EngineError>;
return e.status === 404;
});
} finally {
restore();
}
@@ -146,9 +148,11 @@ test("withdrawApplication: terminal → EngineError 409 (the honest matrix refus
);
try {
const { withdrawApplication, EngineError } = await import(`../lib/engine-client.ts${QS}`);
await assert.rejects(withdrawApplication("app-1", "pilot-learner"), (err: unknown) =>
err instanceof EngineError && err.status === 409,
);
await assert.rejects(withdrawApplication("app-1", "pilot-learner"), (err: unknown) => {
assert.ok(err instanceof EngineError, "must be EngineError");
const e = err as InstanceType<typeof EngineError>;
return e.status === 409;
});
} finally {
restore();
}
@@ -160,10 +164,11 @@ test("getLearnerApplicationStatus: foreign → EngineError 403 (the not-your-app
);
try {
const { getLearnerApplicationStatus, EngineError } = await import(`../lib/engine-client.ts${QS}`);
await assert.rejects(
getLearnerApplicationStatus("app-1", "pilot-learner"),
(err: unknown) => err instanceof EngineError && err.status === 403,
);
await assert.rejects(getLearnerApplicationStatus("app-1", "pilot-learner"), (err: unknown) => {
assert.ok(err instanceof EngineError, "must be EngineError");
const e = err as InstanceType<typeof EngineError>;
return e.status === 403;
});
} finally {
restore();
}