test(pipelines): forward dry_run_override in offline test PapraConfig fixtures #96

2026-06-10T14:10:50Z

backend-engineer commented

2026-06-10 14:10:50 +00:00

Story #93 Traces to: Epic — INB-331 (CEO-routed dispatch). API contract ref: N/A (build-defect fix, no API surface change). Schema ref (Pattern A): N/A (no data model change). Endpoints: N/A. Migrations: N/A. Security review (Pattern D): N/A. What is broken `PapraConfig.init` gained a new keyword-only parameter `dry_run_override` (commit `980cc19` vicinity). Two offline test fixtures in `pipelines/_tests/` construct `PapraConfig(...)` without forwarding this parameter, causing `TypeError` on every branch descending from `main`: - `test_live_pipeline_offline.py`: 4 of 14 tests fail. - `test_historical_pipeline_offline.py`: same signature mismatch (blocked by same regression). Fix Add `dry_run_override=dry_run` to `_make_papra_cfg(...)` in both files. This maps the existing test-level `dry_run` flag into the new parameter, preserving fixture semantics. Verification - `python3 pipelines/_tests/test_live_pipeline_offline.py` → 14/14 passed. - Searched `grep -rn "PapraConfig(" pipelines/_tests/` — all other callsites already include `dry_run_override`. Test plan: CI `Fast offline tests` job should go green on this PR. Reviewer: @cto

## Story #93 **Traces to:** Epic — INB-331 (CEO-routed dispatch). **API contract ref:** N/A (build-defect fix, no API surface change). **Schema ref (Pattern A):** N/A (no data model change). **Endpoints:** N/A. **Migrations:** N/A. **Security review (Pattern D):** N/A. **What is broken** `PapraConfig.__init__` gained a new keyword-only parameter `dry_run_override` (commit `980cc19` vicinity). Two offline test fixtures in `pipelines/_tests/` construct `PapraConfig(...)` without forwarding this parameter, causing `TypeError` on every branch descending from `main`: - `test_live_pipeline_offline.py`: 4 of 14 tests fail. - `test_historical_pipeline_offline.py`: same signature mismatch (blocked by same regression). **Fix** Add `dry_run_override=dry_run` to `_make_papra_cfg(...)` in both files. This maps the existing test-level `dry_run` flag into the new parameter, preserving fixture semantics. **Verification** - `python3 pipelines/_tests/test_live_pipeline_offline.py` → **14/14 passed**. - Searched `grep -rn "PapraConfig(" pipelines/_tests/` — all other callsites already include `dry_run_override`. **Test plan:** CI `Fast offline tests` job should go green on this PR. **Reviewer:** @cto

backend-engineer added 1 commit 2026-06-10 14:10:51 +00:00

test(pipelines): forward dry_run_override in offline test PapraConfig fixtures

InboxOS — PR CI / Fast offline tests (pull_request) Successful in 32s

Details

InboxOS — PR CI / 100MB historical e2e (pull_request) Successful in 11m31s

Details

InboxOS — PR CI / Live Ollama extract smoke (pull_request) Successful in 47s

Details

ff64d7caf9

Fixes main-branch regression where PapraConfig.__init__ gained a new
keyword-only parameter dry_run_override but the two offline test fixtures
did not pass it, causing TypeError on 4/14 live_pipeline tests and
parallel failures in historical_pipeline tests.

- _make_papra_cfg in test_live_pipeline_offline.py: add dry_run_override=dry_run
- _make_papra_cfg in test_historical_pipeline_offline.py: add dry_run_override=dry_run

All PapraConfig callsites in pipelines/_tests now include dry_run_override.
Live offline tests: 14/14 passed.

Refs [INB-331](/INB/issues/INB-331)
Co-Authored-By: Paperclip <noreply@paperclip.ing>

backend-engineer requested review from Ghost Team 2026-06-10 14:10:56 +00:00

backend-engineer referenced this pull request

2026-06-10 14:11:06 +00:00

fix(pipelines): backport dry_run_override to test_live_pipeline_offline.py PapraConfig callsites (regression on main, blocks PR #45 CI) #93

backend-engineer was assigned by cto-ciagent

2026-06-10 14:18:43 +00:00

cto-ciagent added the domain/backend label 2026-06-10 14:18:58 +00:00

backend-engineer added the pillar-iii label 2026-06-10 14:41:37 +00:00

grimacing merged commit 57dad53e57 into main

2026-06-10 15:00:11 +00:00

grimacing deleted branch backend-engineer/fix-dry-run-override-tests

2026-06-10 15:00:11 +00:00