ship: final review + audit + approval-gate prep (P4) #4

2026-09-27T02:23:40Z

coreci-bot commented

2026-09-27 02:23:40 +00:00

Final phase: full-milestone review (PASS-WITH-FIXES — 5 P0s fixed: drawer separators, empty-question guard, border-hairline token, fixture URL honesty, README accuracy) + audit (PASS: reconstruction, discipline, hygiene, tags) + dials/guard unit tests. Gates: 42/42. Milestone merge to main awaits owner approval (REQ-62).

coreci-bot added 2 commits 2026-09-27 02:23:40 +00:00

fix(P04): milestone review P0 fixes — drawer rendering, demo guard, borders, fixture, README 3ee58aa685

---ci---
phase: 4
milestone: v0.1
status: execute
persona: ci-lead-developer
task: T-4.1
requirements:
  covered: [REQ-52, REQ-53, REQ-54, REQ-55, REQ-56, REQ-57, REQ-58, REQ-59, REQ-60, REQ-61]
---/ci---

P0-1: formatDialValue preserves separators — per-claim renders
Per-Claim (was Per+Claim in every drawer); unit tests added.
P0-2: Start research disabled without a question (direct /choose nav
and hard refresh can no longer create empty-question runs); guard
test added.
P0-3: --color-hairline token added to @theme — border-hairline
utility now compiles (21 surfaces were rendering near-black borders);
verified in production CSS.
P0-4: flagship citation URL switched from a real arXiv abs link (which
resolved to an unrelated finance paper) to the example.org fixture
domain, honoring the fixture header's promise; tests updated.
P0-5: root README screens table rewritten — all 5 routes with real
descriptions (was claiming /run/[id] is a placeholder); frontend
README route list + scope note updated.

verify(P04): passed — review PASS-WITH-FIXES closed, audit PASS b7c6ba4a8f

---ci---
phase: 4
milestone: v0.1
status: verify
requirements:
  covered: [REQ-52, REQ-53, REQ-54, REQ-55, REQ-56, REQ-57, REQ-58, REQ-59, REQ-60, REQ-61]
  partial: []
lessons:
  - "full-milestone review: PASS-WITH-FIXES — 5 P0s all fixed in-phase with tests (dials separators, empty-question guard, border-hairline token, fixture URL honesty, README accuracy)"
  - "audit: AUDIT PASS — reconstruction, file discipline, branch hygiene, commit discipline, tag verification, critical issues all green"
  - "border-hairline compiled into production CSS after @theme fix — 21 surfaces were rendering near-black borders"
  - "P1 notes documented for v0.2: report title hardcodes Deep Report shape; getRun fallback lacks demo-run caption"
  - "gates green 42/42 post-fixes; 3-click criterion still pinned"
---/ci---

coreci-bot merged commit 1d97788e5d into milestone/v0.1-prototype

2026-09-27 02:23:44 +00:00

coreci-bot deleted branch phase/04-final-review-approval-ship

2026-09-27 02:23:44 +00:00

coreci-bot referenced this issue from a commit

2026-09-27 02:24:05 +00:00

docs(P04): final phase shipped — pipeline HALTED at owner approval gate (REQ-62)

coreci-researchx-po referenced this pull request

2026-10-20 04:13:21 +00:00

Project: comms-etiquette v1.0 pass — work package (coreci/researchx) #22

Sign in to join this conversation.