fix(review): P1 fixes — adapter dedup validation + inventory summary
acdl-ci / Lint (pull_request) Successful in 9s
acdl-ci / Platform check-only (offline) (pull_request) Successful in 31s
acdl-modules-lifecycle / CI VPC apply (pull_request) Successful in 42s
acdl-ci / Test (pull_request) Successful in 4m47s
acdl-modules-lifecycle / L1 lifecycle (alb) (pull_request) Failing after 1m20s
acdl-modules-lifecycle / L1 lifecycle (cloudfront) (pull_request) Failing after 1m18s
acdl-modules-lifecycle / L1 lifecycle (ecr) (pull_request) Successful in 2m53s
acdl-modules-lifecycle / L1 lifecycle (ecs-cluster) (pull_request) Successful in 3m14s
acdl-modules-lifecycle / L1 lifecycle (iam-role) (pull_request) Successful in 2m49s
acdl-modules-lifecycle / L1 lifecycle (ecs-service) (pull_request) Failing after 5m24s
acdl-modules-lifecycle / L1 lifecycle (kms-key) (pull_request) Failing after 1m39s
acdl-modules-lifecycle / L1 lifecycle (rds) (pull_request) Failing after 1m20s
acdl-modules-lifecycle / L1 lifecycle (s3) (pull_request) Successful in 3m18s
acdl-modules-lifecycle / L1 lifecycle (vpc) (pull_request) Successful in 2m55s
acdl-modules-lifecycle / L1 lifecycle (uptime) (pull_request) Failing after 5m25s
acdl-modules-lifecycle / L2 lifecycle (microservice) (pull_request) Failing after 1m1s
acdl-modules-lifecycle / L2 lifecycle (static-assets) (pull_request) Failing after 1m29s
acdl-modules-lifecycle / L1 lifecycle (waf) (pull_request) Successful in 3m21s
acdl-modules-lifecycle / CI VPC destroy (pull_request) Failing after 20m46s

P1-1: Adapter dedup now raises ValueError when a module isn't in the
registry (previously silently dropped unknown-module resources — the
exact defect class the v1.10 sweep was built to catch).

P1-4: CAPABILITY_INVENTORY summary table updated from 16 to 22 (6 new
CAP-017..022 added in v1.11). Headline and body now agree.

Adapter: 196 lines (still under 200).
Regression: 485 passed, 5 deselected.

---ci---
project: acdl
phase: 0
milestone: v1.11
status: review
---/ci---
This commit is contained in:
Jon Chery
2026-07-29 12:32:31 +00:00
parent 073afcfe84
commit ec3b2dd9eb
2 changed files with 8 additions and 5 deletions
+4 -2
View File
@@ -159,13 +159,15 @@ def adapt(stack_instance, out_dir):
seen = {} # terraform_dir → resource
for r in resources:
tf_dir = terraform_dirs.get(_module_name(r))
if tf_dir and tf_dir in seen:
if not tf_dir:
raise ValueError(f"no terraform_dir in registry for module '{_module_name(r)}' (resource {r['id']})")
if tf_dir in seen:
for k, v in r.get("inputs", {}).items():
if k != "region" and k not in seen[tf_dir].get("inputs", {}):
seen[tf_dir].setdefault("inputs", {})[k] = v
for k, v in r.get("outputs", {}).items():
seen[tf_dir].setdefault("outputs", {})[k] = v
elif tf_dir:
else:
seen[tf_dir] = r
merged = list(seen.values()) if seen else resources
parts.extend(_emit_module_block(r, terraform_dirs, repo_root, set(data_source_names)) for r in merged)